RussellSpitzer commented on a change in pull request #4376:
URL: https://github.com/apache/iceberg/pull/4376#discussion_r833379640
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -486,6 +486,7 @@ private static PartitionSpec toPartitionSpec(List<String>
partitionKeys, Schema
return builder.build();
}
+ @SuppressWarnings("MixedMutabilityReturnType")
Review comment:
Not a huge deal, but couldn't we fix this by just using an immutable
list builder? That way we would have the same mutability in the return type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
