kbendick commented on a change in pull request #4405:
URL: https://github.com/apache/iceberg/pull/4405#discussion_r836934170
##########
File path: core/src/main/java/org/apache/iceberg/rest/RESTClient.java
##########
@@ -27,9 +27,14 @@
* Interface for a basic HTTP Client for interfacing with the REST catalog.
*/
public interface RESTClient extends Closeable {
- <T> T delete(String path, Class<T> responseType, Consumer<ErrorResponse>
errorHandler);
- <T> T post(String path, Object body, Class<T> responseType,
Consumer<ErrorResponse> errorHandler);
- <T> T get(String path, Class<T> responseType, Consumer<ErrorResponse>
errorHandler);
- void head(String path, Consumer<ErrorResponse> errorHandler);
+
+ void head(String path, Consumer<ErrorResponse> errorHandler);
+
+ <T extends RESTResponse<T>> T delete(String path, Class<T> responseType,
Consumer<ErrorResponse> errorHandler);
+
+ <T extends RESTResponse<T>> T get(String path, Class<T> responseType,
Consumer<ErrorResponse> errorHandler);
+
+ <T extends RESTResponse<T>> T post(
+ String path, Object body, Class<T> responseType, Consumer<ErrorResponse>
errorHandler);
Review comment:
Style wise, I wasn't really sure the best way to deal with these.
Specifically because `post` would require multiple lines for the arguments.
I moved `head` up because it returns `void` now.
Please feel free to make suggestions @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
