kbendick commented on a change in pull request #4405:
URL: https://github.com/apache/iceberg/pull/4405#discussion_r838943118
##########
File path: core/src/main/java/org/apache/iceberg/rest/HTTPClient.java
##########
@@ -201,17 +201,20 @@ public void head(String path, Consumer<ErrorResponse>
errorHandler) {
}
@Override
- public <T> T get(String path, Class<T> responseType, Consumer<ErrorResponse>
errorHandler) {
+ public <T extends RESTResponse> T get(String path, Class<T> responseType,
+ Consumer<ErrorResponse> errorHandler) {
return execute(Method.GET, path, null, responseType, errorHandler);
}
@Override
- public <T> T post(String path, Object body, Class<T> responseType,
Consumer<ErrorResponse> errorHandler) {
+ public <T extends RESTResponse> T post(String path, Object body, Class<T>
responseType,
Review comment:
Yeah. I used just `RESTRequest` here, but not certain if it needs to be
another type variable here for post of like `<Req extends RESTRequst>`.
I think just using `RESTRequest` is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
