kbendick commented on a change in pull request #4405: URL: https://github.com/apache/iceberg/pull/4405#discussion_r836949381
########## File path: core/src/main/java/org/apache/iceberg/rest/RESTResponse.java ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest; + +/** + * Interface to mark a REST response + */ +public interface RESTResponse extends RESTMessage<RESTResponse> { +} Review comment: Initially, I had this as `RESTResponse<T> extends RESTMessage<T>`. Arguably that's more type safe, but it required _every single_ request / response object to redeclare itself twice. I think it's sufficient to just have type checking on the fact that it's a request or a response, as it would be unlikely to define a class with a `validate` method that returns some other `RESTRequest` or `RESTResponse`. If we think this trade off isn't worth it, I can revert the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
