stevenzwu commented on code in PR #4529:
URL: https://github.com/apache/iceberg/pull/4529#discussion_r846524714
##########
api/src/main/java/org/apache/iceberg/TableScan.java:
##########
@@ -147,8 +147,25 @@ default TableScan select(String... columns) {
* @param toSnapshotId read append data up to this snapshot id
* @return a table scan which can read append data from {@code
fromSnapshotId}
* exclusive and up to {@code toSnapshotId} inclusive
+ *
+ * @deprecated Please use the appendsBetween with non-primitive
fromSnapshotId of Long type
+ */
+ @Deprecated
+ default TableScan appendsBetween(long fromSnapshotId, long toSnapshotId) {
+ return appendsInRange(Long.valueOf(fromSnapshotId), toSnapshotId);
+ }
+
+ /**
+ * Create a new {@link TableScan} to read appended data from {@code
fromSnapshotId} exclusive to {@code toSnapshotId}
+ * inclusive.
+ *
+ * @param fromSnapshotId the last snapshot id read by the user, exclusive.
If it is null,
+ * all the ancestor snapshots of the toSnapshotId
should be discovered
+ * @param toSnapshotId read append data up to this snapshot id
+ * @return a table scan which can read append data from {@code
fromSnapshotId}
+ * exclusive and up to {@code toSnapshotId} inclusive
*/
- TableScan appendsBetween(long fromSnapshotId, long toSnapshotId);
+ TableScan appendsInRange(Long fromSnapshotId, long toSnapshotId);
Review Comment:
Another naming option is `appendsBetweenScan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
