stevenzwu commented on code in PR #4529:
URL: https://github.com/apache/iceberg/pull/4529#discussion_r846528568
##########
core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java:
##########
@@ -60,7 +60,7 @@ public void testInvalidScans() {
AssertHelpers.assertThrows(
"from and to snapshots cannot be the same, since from snapshot is
exclusive and not part of the scan",
IllegalArgumentException.class, "from and to snapshot ids cannot be
the same",
- () -> appendsBetweenScan(1, 1));
+ () -> appendsBetweenScan(1L, 1L));
Review Comment:
Since we changed the arg type from long to Long for `fromSnapshotId` param
in `appendsBetweenScan` method, we need to change the from `1` to `1L`. there
is no auto type conversion from `int` to `Long`.
Since I am changing the constants for `fromSnapshotId`, I also changed the
`toSnapshotId` as well to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
