aokolnychyi commented on code in PR #4503:
URL: https://github.com/apache/iceberg/pull/4503#discussion_r846544708


##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -80,6 +80,19 @@
    */
   DeleteOrphanFiles executeDeleteWith(ExecutorService executorService);
 
+  /**
+   * Passes a table which contains the list of actual files in the table. This 
skips the directory listing - any
+   * files in the actualFilesTable provided which are not found in table 
metadata will be deleted. Not compatible
+   * with `location` or `older_than` arguments - this assumes that the 
provided table of actual files has been

Review Comment:
   I would even consider making it required. How many people will filter the 
locations manually before calling the action?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to