bijanhoule commented on PR #4503: URL: https://github.com/apache/iceberg/pull/4503#issuecomment-1097096902
Thanks for the feedback all! I'll take another pass and adjust a few things: - move to the spark-specific api and use a dataset input rather than temp table - add support for `modified_time` and enforce `older_than`. Originally the thought was to keep this out for simplicity, but I agree it's probably safer to just make it a requirement. - separate out test cases and add coverage for the above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
