bijanhoule commented on code in PR #4503:
URL: https://github.com/apache/iceberg/pull/4503#discussion_r854466219
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java:
##########
@@ -144,6 +154,37 @@ public BaseDeleteOrphanFilesSparkAction
deleteWith(Consumer<String> newDeleteFun
return this;
}
+ public BaseDeleteOrphanFilesSparkAction compareToFileList(Dataset<Row>
files) {
+ StructType schema = files.schema();
+
+ StructField filePathField = schema.apply(FILE_PATH);
+ Preconditions.checkArgument(
+ filePathField.dataType() == DataTypes.StringType,
+ "Invalid %s column: %s is not a string",
+ FILE_PATH,
+ filePathField.dataType());
+
+ StructField lastModifiedField = schema.apply(LAST_MODIFIED);
+ Preconditions.checkArgument(
+ lastModifiedField.dataType() == DataTypes.TimestampType,
+ "Invalid %s column: %s is not a timestamp",
+ LAST_MODIFIED,
+ lastModifiedField.dataType());
+
+ this.compareToFileList = files;
+ return this;
+ }
+
+ private Dataset<Row> filteredCompareToFileList() {
+ Dataset<Row> files = compareToFileList;
+ if (location != null) {
+ files = files.filter(files.col(FILE_PATH).startsWith(location));
+ }
Review Comment:
@aokolnychyi -- re:
https://github.com/apache/iceberg/pull/4503#discussion_r846544708 does this
`startsWith` location filtering seem reasonable to you for a short-term
solution? I know there's some discussion about making some larger changes
[here](https://github.com/apache/iceberg/issues/4346).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
