singhpk234 commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r849421024
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -267,4 +299,9 @@ private <T> Iterable<CloseableIterable<T>> entries(
return entryFn.apply(manifest, entries);
});
}
+
+ private boolean hasDeletes(ManifestEntry<DataFile> entry, DeleteFileIndex
deleteFiles) {
+ DeleteFile[] deleteFileArray = deleteFiles.forEntry(entry);
+ return deleteFileArray.length > 0;
+ }
Review Comment:
since deleteFilesIndex can now be null, should we add a null check here ?
Ideally we shouldn't be reaching here when deleteFilesIndex are null
considering it's passed only from data files perspective. Your thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
