kbendick commented on code in PR #4539:
URL: https://github.com/apache/iceberg/pull/4539#discussion_r851584132
##########
api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java:
##########
@@ -74,4 +74,11 @@ default ExpireSnapshots expireSnapshots(Table table) {
default DeleteReachableFiles deleteReachableFiles(String metadataLocation) {
throw new UnsupportedOperationException(this.getClass().getName() + " does
not implement deleteReachableFiles");
}
+
+ /**
+ * Instantiates an action to generate CDC records.
+ */
+ default Cdc generateCdcRecords(Table table) {
Review Comment:
Yeah I agree that using a full word would be better.
In comments and even method names it's fine in my opinion but as the main
class name it probably would be best to use the full name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
