aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r850878470
##########
core/src/main/java/org/apache/iceberg/AllDataFilesTable.java:
##########
@@ -53,47 +48,25 @@ MetadataTableType metadataTableType() {
return MetadataTableType.ALL_DATA_FILES;
}
- public static class AllDataFilesTableScan extends BaseFilesTableScan {
+ public static class AllDataFilesTableScan extends BaseAllFilesTableScan {
- AllDataFilesTableScan(TableOperations ops, Table table, Schema fileSchema)
{
- super(ops, table, fileSchema, MetadataTableType.ALL_DATA_FILES);
+ AllDataFilesTableScan(TableOperations ops, Table table, Schema schema) {
Review Comment:
I took a closer look and it seems it is not really `fileSchema`. It is more
like a metadata table schema before column pruning. That's the purpose of that
variable in `BaseTableScan`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
