aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r851424146
##########
core/src/main/java/org/apache/iceberg/AllEntriesTable.java:
##########
@@ -88,34 +83,16 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
}
@Override
- protected String tableType() {
- return MetadataTableType.ALL_ENTRIES.name();
- }
+ protected CloseableIterable<FileScanTask> doPlanFiles() {
+ CloseableIterable<ManifestFile> manifests =
allManifests(Snapshot::allManifests);
- @Override
- protected CloseableIterable<FileScanTask> planFiles(
- TableOperations ops, Snapshot snapshot, Expression rowFilter,
- boolean ignoreResiduals, boolean caseSensitive, boolean colStats) {
- CloseableIterable<ManifestFile> manifests = allManifestFiles(
- ops.current().snapshots(), context().planExecutor());
String schemaString = SchemaParser.toJson(schema());
String specString =
PartitionSpecParser.toJson(PartitionSpec.unpartitioned());
- Expression filter = ignoreResiduals ? Expressions.alwaysTrue() :
rowFilter;
+ Expression filter = shouldIgnoreResiduals() ? Expressions.alwaysTrue() :
filter();
Review Comment:
I think it may be something related to having `ignoreResiduals()` that acts
like a setter. I'll have to check the existing implementation. I used what was
already available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
