szehon-ho commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r851444055
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -56,72 +56,73 @@ public Schema schema() {
}
}
- abstract static class BaseFilesTableScan extends BaseMetadataTableScan {
+ private static CloseableIterable<FileScanTask> planFiles(Table table,
CloseableIterable<ManifestFile> manifests,
+ Schema tableSchema,
Schema projectedSchema,
+ TableScanContext
context) {
+ Expression rowFilter = context.rowFilter();
+ boolean caseSensitive = context.caseSensitive();
+ boolean ignoreResiduals = context.ignoreResiduals();
+
+ LoadingCache<Integer, ManifestEvaluator> evalCache =
Caffeine.newBuilder().build(specId -> {
Review Comment:
Yea no problem, I can look at it later, it's part of the code but not the
whole thing as PartitionsTable creates another kind of FileScanTask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
