RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r855322628
##########
core/src/main/java/org/apache/iceberg/deletes/Deletes.java:
##########
@@ -133,11 +158,17 @@ protected EqualitySetDeleteFilter(Function<T, StructLike>
extractEq,
@Override
protected boolean shouldKeep(T row) {
- return !deletes.contains(extractEqStruct.apply(row));
+ boolean keep = !deletes.contains(extractEqStruct.apply(row));
+ if (!keep) {
Review Comment:
I'm not sure these trace messages will be very valuable, do you think we
need them for the metric code or where they just temporary for testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
