RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r855334798
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -172,7 +185,8 @@ public CloseableIterable<T>
findEqualityDeleteRows(CloseableIterable<T> records)
Filter<T> deletedRowsFilter = new Filter<T>() {
@Override
protected boolean shouldKeep(T item) {
- return deletedRows.test(item);
+ boolean keep = deletedRows.test(item); // true means row is deleted
Review Comment:
This probably can be reverted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
