RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r855340336


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java:
##########
@@ -75,6 +86,7 @@ CloseableIterator<ColumnarBatch> open(FileScanTask task) {
     InputFile location = getInputFile(task);
     Preconditions.checkNotNull(location, "Could not find InputFile associated 
with FileScanTask");
     if (task.file().format() == FileFormat.PARQUET) {
+      LOG.debug("data file is parquet; calling deleteFilter to get 
SparkDeleteFilter ...");

Review Comment:
   Capital? But maybe remove this one, not sure it's adding a lot of value 
since you could just add the line in the `deleteFilter` code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to