RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r855348221
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -193,15 +204,41 @@ public boolean supportColumnarReads(InputPartition
partition) {
}
}
+ static long numFilesToScan(CombinedScanTask scanTask) {
+ long fileCount = 0L;
+ for (FileScanTask file : scanTask.files()) {
+ fileCount += 1L;
+ }
+ return fileCount;
Review Comment:
why not just scanTask.files().size?
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScan.java:
##########
@@ -193,15 +204,41 @@ public boolean supportColumnarReads(InputPartition
partition) {
}
}
+ static long numFilesToScan(CombinedScanTask scanTask) {
+ long fileCount = 0L;
+ for (FileScanTask file : scanTask.files()) {
+ fileCount += 1L;
+ }
+ return fileCount;
Review Comment:
How about scanTask.files().size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
