aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r855696837
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -78,23 +76,23 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
}
@Override
- public CloseableIterable<FileScanTask> planFiles(TableOperations ops,
Snapshot snapshot,
- Expression rowFilter,
boolean ignoreResiduals,
- boolean caseSensitive,
boolean colStats) {
- ManifestGroup manifestGroup = new ManifestGroup(ops.io(),
snapshot.dataManifests(), snapshot.deleteManifests())
- .caseSensitive(caseSensitive)
- .select(colStats ? SCAN_WITH_STATS_COLUMNS : SCAN_COLUMNS)
- .filterData(rowFilter)
- .specsById(ops.current().specsById())
+ public CloseableIterable<FileScanTask> doPlanFiles() {
+ Snapshot snapshot = snapshot();
+
+ ManifestGroup manifestGroup = new ManifestGroup(table().io(),
snapshot.dataManifests(), snapshot.deleteManifests())
+ .caseSensitive(isCaseSensitive())
+ .select(colStats() ? SCAN_WITH_STATS_COLUMNS : SCAN_COLUMNS)
+ .filterData(filter())
+ .specsById(table().specs())
.ignoreDeleted();
- if (ignoreResiduals) {
+ if (shouldIgnoreResiduals()) {
Review Comment:
I cann't because of a conflicting setter method discussed
[here](https://github.com/apache/iceberg/pull/4566#discussion_r855626731).
##########
core/src/main/java/org/apache/iceberg/DataTableScan.java:
##########
@@ -78,23 +76,23 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
}
@Override
- public CloseableIterable<FileScanTask> planFiles(TableOperations ops,
Snapshot snapshot,
- Expression rowFilter,
boolean ignoreResiduals,
- boolean caseSensitive,
boolean colStats) {
- ManifestGroup manifestGroup = new ManifestGroup(ops.io(),
snapshot.dataManifests(), snapshot.deleteManifests())
- .caseSensitive(caseSensitive)
- .select(colStats ? SCAN_WITH_STATS_COLUMNS : SCAN_COLUMNS)
- .filterData(rowFilter)
- .specsById(ops.current().specsById())
+ public CloseableIterable<FileScanTask> doPlanFiles() {
+ Snapshot snapshot = snapshot();
+
+ ManifestGroup manifestGroup = new ManifestGroup(table().io(),
snapshot.dataManifests(), snapshot.deleteManifests())
+ .caseSensitive(isCaseSensitive())
+ .select(colStats() ? SCAN_WITH_STATS_COLUMNS : SCAN_COLUMNS)
+ .filterData(filter())
+ .specsById(table().specs())
.ignoreDeleted();
- if (ignoreResiduals) {
+ if (shouldIgnoreResiduals()) {
Review Comment:
I can't because of a conflicting setter method discussed
[here](https://github.com/apache/iceberg/pull/4566#discussion_r855626731).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
