aokolnychyi commented on code in PR #4566:
URL: https://github.com/apache/iceberg/pull/4566#discussion_r855627397
##########
core/src/main/java/org/apache/iceberg/AllDataFilesTable.java:
##########
@@ -53,47 +48,25 @@ MetadataTableType metadataTableType() {
return MetadataTableType.ALL_DATA_FILES;
}
- public static class AllDataFilesTableScan extends BaseFilesTableScan {
+ public static class AllDataFilesTableScan extends BaseAllFilesTableScan {
- AllDataFilesTableScan(TableOperations ops, Table table, Schema fileSchema)
{
- super(ops, table, fileSchema, MetadataTableType.ALL_DATA_FILES);
+ AllDataFilesTableScan(TableOperations ops, Table table, Schema schema) {
Review Comment:
Okay, that's why. I think it still makes sense to rename as I got rid of a
separate `fileSchema` var.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
