snazy commented on code in PR #4700:
URL: https://github.com/apache/iceberg/pull/4700#discussion_r865763337
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -87,7 +87,9 @@ public void refresh() throws NessieNotFoundException {
}
public NessieIcebergClient withReference(String requestedRef, String hash) {
- if (null == requestedRef) {
+ if (null == requestedRef ||
+ getRef().getReference().getName().equals(requestedRef) ||
+ getRef().getHash().equals(hash)) {
Review Comment:
Sure that you want equals on ref-name _OR_ hash? I.e. still return `this`,
if the branch name doesn't change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
