nastra commented on code in PR #4700:
URL: https://github.com/apache/iceberg/pull/4700#discussion_r866736879
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -87,7 +87,9 @@ public void refresh() throws NessieNotFoundException {
}
public NessieIcebergClient withReference(String requestedRef, String hash) {
- if (null == requestedRef) {
+ if (null == requestedRef ||
+ getRef().getReference().getName().equals(requestedRef) ||
Review Comment:
good point, I guess worst case we have to do a REST call when using
`client.withReference(branchName, null)`, which is sub-optional but still
better than actually using an underlying reference with a commit that's outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
