ajantha-bhat commented on code in PR #4700:
URL: https://github.com/apache/iceberg/pull/4700#discussion_r866706169
##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -87,7 +87,9 @@ public void refresh() throws NessieNotFoundException {
}
public NessieIcebergClient withReference(String requestedRef, String hash) {
- if (null == requestedRef) {
+ if (null == requestedRef ||
+ getRef().getReference().getName().equals(requestedRef) ||
+ getRef().getHash().equals(hash)) {
Review Comment:
> at this point yes, because Trino will make heavier use of this method and
we don't want to do another REST call to fetch the branch if it didn't change
but functionally it is wrong in case of "drop a reference and create new
reference with same name but different hash/source"
Can we make trino pass the hash as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
