dramaticlly commented on code in PR #4730:
URL: https://github.com/apache/iceberg/pull/4730#discussion_r868221402
##########
python/src/iceberg/table/partitioning.py:
##########
@@ -24,7 +24,7 @@ class PartitionField:
Attributes:
source_id(int): The source column id of table's schema
- field_id(int): The partition field id across all the table metadata's
partition specs
+ field_id(int): The partition field id across all the table partition
metadata specs
Review Comment:
nit: I think [partition
spec](https://iceberg.apache.org/spec/#partition-specs) here refer to a single
entity in iceberg jargon, so I feel `partition metadata specs` does not confer
the same meaning
##########
python/spellcheck-dictionary.txt:
##########
@@ -0,0 +1,33 @@
+accessor
Review Comment:
just curious, do we need to manually maintain the private dictionary going
forward?
##########
python/spellcheck-dictionary.txt:
##########
@@ -0,0 +1,33 @@
+accessor
Review Comment:
also I am curious, do we need both `python/spellcheck-dictionary.txt` and
top level `spellcheck-dictionary.txt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
