rdblue commented on code in PR #4730:
URL: https://github.com/apache/iceberg/pull/4730#discussion_r868749741
##########
python/src/iceberg/table/partitioning.py:
##########
@@ -24,7 +24,7 @@ class PartitionField:
Attributes:
source_id(int): The source column id of table's schema
- field_id(int): The partition field id across all the table metadata's
partition specs
+ field_id(int): The partition field id across all the table partition
specs' metadata
Review Comment:
This changes the meaning. "Table metadata" refers to all of the metadata,
and "table metadata's partition specs" is the set of partition specs in table
metadata. "Partition specs' metadata" is narrower, the metadata across
partition specs.
To fix this, I think you can just omit "metadata": "across all the table's
partition specs".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
