Fokko commented on code in PR #4730: URL: https://github.com/apache/iceberg/pull/4730#discussion_r868352290
########## python/spellcheck-dictionary.txt: ########## @@ -0,0 +1,33 @@ +accessor Review Comment: > just curious, do we need to manually maintain the private dictionary going forward? Yes, once there is special jargon that's outside of the English dictionary, we need to add this. > also I am curious, do we need both python/spellcheck-dictionary.txt and top level spellcheck-dictionary.txt? Yes, in that case, we would have another dictionary, but a better option would be to move it to the top level. Or in `dev/` to keep the top-level nice and clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
