kbendick commented on code in PR #4734:
URL: https://github.com/apache/iceberg/pull/4734#discussion_r868330842
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -297,7 +297,9 @@ public void testNoNulls() {
}
@Test
- public void testIsNaN() {
+ public void testIsNaNForParquet() {
Review Comment:
Nit: You don't need to change the test name, because the `Assume` will take
care of it and signal that in the tests.
For people that maintain forks and cherry-pick individual changes, updating
the test name will probably cause them more of headache than is worth it.
Also, I would consider using `Assume.assumeTrue("Parquet metrics do not
track NaN", format == FileFormat.PARQUET)` unless this should also possibly run
someday for Avro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
