kbendick commented on code in PR #4734:
URL: https://github.com/apache/iceberg/pull/4734#discussion_r868341986
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -311,6 +313,14 @@ public void testIsNaN() {
Assert.assertFalse("Should skip: all null column will not contain nan
value", shouldRead);
}
+ @Test
+ public void testIsNaNForORC() {
+ Assume.assumeFalse("Not for Parquet files", format == FileFormat.PARQUET);
Review Comment:
Also, I think some of the tests from above can be repeated for each file
format.
Like the `all_nulls` etc. Can you please add all of those statements for
both file formats? That is, add an assertion on reading `all_nans`,
`some_nans`, `no_nans`, and `all_nulls` in the ORC tests. Right now, the ORC
test is only checking `no_nans` but we should verify the correct behavior for
all of those with ORC as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
