kbendick commented on code in PR #4734:
URL: https://github.com/apache/iceberg/pull/4734#discussion_r868332048
##########
data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java:
##########
@@ -311,6 +313,14 @@ public void testIsNaN() {
Assert.assertFalse("Should skip: all null column will not contain nan
value", shouldRead);
}
+ @Test
+ public void testIsNaNForORC() {
+ Assume.assumeFalse("Not for Parquet files", format == FileFormat.PARQUET);
Review Comment:
Same note about the `Assume` statement.
I would just put `Assume.assumeTrue(format == FileFormat.ORC)` unless you
think that Avro should also be included here.
Many of the `Assume` statements don't seem to give a reason phrase at all,
but if you do want to include one, I'd give a specific reason why (e.g.
`Assume.assumeTrue("ORC files track NaN counts in their statistics", format ==
FileFormat.ORC);`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
