rdblue commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r878343297
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -233,25 +233,25 @@ public void applyTo(TableMetadata.Builder
metadataBuilder) {
}
class SetSnapshotRef implements MetadataUpdate {
- private final String name;
+ private final String refName;
private final Long snapshotId;
private final SnapshotRefType type;
private Integer minSnapshotsToKeep;
private Long maxSnapshotAgeMs;
private Long maxRefAgeMs;
- public SetSnapshotRef(String name, Long snapshotId, SnapshotRefType type,
Integer minSnapshotsToKeep,
+ public SetSnapshotRef(String refName, Long snapshotId, SnapshotRefType
type, Integer minSnapshotsToKeep,
Long maxSnapshotAgeMs, Long maxRefAgeMs) {
- this.name = name;
+ this.refName = refName;
this.snapshotId = snapshotId;
this.type = type;
this.minSnapshotsToKeep = minSnapshotsToKeep;
this.maxSnapshotAgeMs = maxSnapshotAgeMs;
this.maxRefAgeMs = maxRefAgeMs;
}
- public String name() {
- return name;
+ public String refName() {
Review Comment:
Probably better not to rename this, since it requires touching two extra
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
