kbendick commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r879791312
##########
core/src/test/java/org/apache/iceberg/TestMetadataUpdateParser.java:
##########
@@ -251,11 +274,122 @@ public void testAddSortOrderFromJson() {
assertEquals(action, expected, MetadataUpdateParser.fromJson(json));
}
+ @Test
+ public void testSetDefaultSortOrderToJson() {
+ String action = MetadataUpdateParser.SET_DEFAULT_SORT_ORDER;
+ int sortOrderId = 2;
+ String expected =
String.format("{\"action\":\"%s\",\"sort-order-id\":%d}", action, sortOrderId);
+ MetadataUpdate update = new
MetadataUpdate.SetDefaultSortOrder(sortOrderId);
+ String actual = MetadataUpdateParser.toJson(update);
+ Assert.assertEquals("Set default sort order should serialize to the
correct JSON value", expected, actual);
+ }
+
+ @Test
+ public void testSetDefaultSortOrderFromJson() {
+ String action = MetadataUpdateParser.SET_DEFAULT_SORT_ORDER;
+ int sortOrderId = 2;
+ String json = String.format("{\"action\":\"%s\",\"sort-order-id\":%d}",
action, sortOrderId);
+ MetadataUpdate expected = new
MetadataUpdate.SetDefaultSortOrder(sortOrderId);
+ assertEquals(action, expected, MetadataUpdateParser.fromJson(json));
+ }
+
+ // TODO - AddSnapshot tests.
+
+ // TODO - Tests that handle multiple snapshot ids.
+ @Test
+ public void testRemoveSnapshotsFromJson() {
Review Comment:
Yeah I moved forward with just 1 allowed. Would you like me to change the
class name to be singular for now? Currently the singular constructor class is
`RemovePartitions`.
We can either accept one value and then collect it into a set and expose two
constructors or make two classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
