kbendick commented on code in PR #4716:
URL: https://github.com/apache/iceberg/pull/4716#discussion_r878356165


##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -250,6 +251,8 @@ public SetSnapshotRef(String name, Long snapshotId, 
SnapshotRefType type, Intege
       this.maxRefAgeMs = maxRefAgeMs;
     }
 
+    // TODO - Consider renaming to `refName`, as the JSON is called `ref`. 
This also matches the equivalent
+    //  UpdateRequirement.
     public String name() {

Review Comment:
   Change tot he code has been reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to