kbendick commented on code in PR #4825:
URL: https://github.com/apache/iceberg/pull/4825#discussion_r878591654
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -420,7 +420,7 @@ public void testOlderThanTimestamp() throws
InterruptedException {
long timestamp = System.currentTimeMillis();
- waitUntilAfter(System.currentTimeMillis());
+ waitUntilAfter(System.currentTimeMillis() + 1000L);
Review Comment:
What would be better, if possible, would be to access the timestamp from the
snapshot summary and then wait until after that (which is what we do in many
other tests).
However, given that this is a Spark test, the time it would take to access
the summary from the commit means that it would likely take longer to do that
than any of the `waitUntilAfter` (i.e. that time would likely have passed by at
least a few hundred milliseconds on any machine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
