sumeetgajjar commented on code in PR #4825:
URL: https://github.com/apache/iceberg/pull/4825#discussion_r878848478
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -420,7 +420,7 @@ public void testOlderThanTimestamp() throws
InterruptedException {
long timestamp = System.currentTimeMillis();
- waitUntilAfter(System.currentTimeMillis());
+ waitUntilAfter(System.currentTimeMillis() + 1000L);
Review Comment:
So I believe in this explicit case, using the timestamp from the snapshot
summary won't be useful. The primary reason being we are trying to delete
parquet files at the "data/c2_trunc=AA/c3=AAAA" location which are not managed
by Iceberg.
https://github.com/apache/iceberg/blob/566b2fe3f31f4a53f5a26aca1c4239085de4a994/spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java#L416-L417
Had it been the case if the supposed to be orphan files were created using
iceberg we could have leveraged the timestamp from the snapshot summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
