rdblue commented on code in PR #4825:
URL: https://github.com/apache/iceberg/pull/4825#discussion_r880991367
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -420,7 +420,7 @@ public void testOlderThanTimestamp() throws
InterruptedException {
long timestamp = System.currentTimeMillis();
- waitUntilAfter(System.currentTimeMillis());
+ waitUntilAfter(System.currentTimeMillis() + 1000L);
Review Comment:
I think the point is still valid. `waitUntilAfter` should be used so that
you know that a certain amount of time, in milliseconds, has elapsed. That
gives you the ability to create one file, wait until the next millisecond,
create another, wait, etc. to make sure they don't have the same write time. It
doesn't need to be a snapshot timestamp, but you shouldn't need to wait for an
entire second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
