kbendick commented on code in PR #4825:
URL: https://github.com/apache/iceberg/pull/4825#discussion_r881230284


##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -420,7 +420,7 @@ public void testOlderThanTimestamp() throws 
InterruptedException {
 
     long timestamp = System.currentTimeMillis();
 
-    waitUntilAfter(System.currentTimeMillis());
+    waitUntilAfter(System.currentTimeMillis() + 1000L);

Review Comment:
   @sumeetgajjar left a comment on the main page of this PR, but check out the 
solution we came up with in another PR / issue discussion: 
https://github.com/apache/iceberg/pull/4859
   
   We noticed a different test in this suite fail in GitHub CI as well. We just 
made the `olderThan` argument in the future to account for it the time 
precision issue without having to do excessive busy waiting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to