kbendick commented on code in PR #4866:
URL: https://github.com/apache/iceberg/pull/4866#discussion_r882886649
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -117,6 +118,7 @@ private MetadataUpdateParser() {
.put(MetadataUpdate.AddSnapshot.class, ADD_SNAPSHOT)
.put(MetadataUpdate.RemoveSnapshot.class, REMOVE_SNAPSHOTS)
.put(MetadataUpdate.SetSnapshotRef.class, SET_SNAPSHOT_REF)
+ .put(MetadataUpdate.RemoveSnapshotRef.class, REMOVE_SNAPSHOT_REF)
Review Comment:
Nit: Same thing about moving this to be below `REMOVE_SNAPSHOTS`.
I'll just leave this comment to mention that this applies everywhere if
possible =)
Having the classes aligned in the file the same way they're written in the
`MetadataUpdate` file helps with aligning things and finding the right thing
(at least for me).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
