kbendick commented on code in PR #4866:
URL: https://github.com/apache/iceberg/pull/4866#discussion_r882886291
##########
core/src/main/java/org/apache/iceberg/MetadataUpdate.java:
##########
@@ -216,19 +216,19 @@ public void applyTo(TableMetadata.Builder
metadataBuilder) {
}
class RemoveSnapshotRef implements MetadataUpdate {
- private final String name;
+ private final String refName;
Review Comment:
👍 This change is good. If somebody were to implement their own small enums
in another language or with something that could go from kebab-case to
camel-case automatically, then this change would be sufficient to allow them to
update the parser themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
