kbendick commented on code in PR #4866:
URL: https://github.com/apache/iceberg/pull/4866#discussion_r882975398
##########
core/src/main/java/org/apache/iceberg/MetadataUpdateParser.java:
##########
@@ -324,6 +331,12 @@ private static void
writeSetSnapshotRef(MetadataUpdate.SetSnapshotRef update, Js
JsonUtil.writeLongFieldIf(update.maxRefAgeMs() != null, MAX_REF_AGE_MS,
update.maxRefAgeMs(), gen);
}
+ private static void writeRemoveSnapshotRef(
+ MetadataUpdate.RemoveSnapshotRef update,
+ JsonGenerator gen) throws IOException {
Review Comment:
Nit: if this could be on one line, possibly with the `throws IOException` on
its own line if it doesn't all fit on one line, that would be great / fit what
is done elsewhere.
But I wouldn't block on this PR for that.
```java
private static void
writeRemoveSnapshotRef(MetadataUpdate.RemoveSnapshotRef update, JsonGenerater
gen)
throws IOException {
gen.writeStringField(REF_NAME, update.name());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
