RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r888049460
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -67,22 +72,26 @@
private final List<DeleteFile> eqDeletes;
private final Schema requiredSchema;
private final Accessor<StructLike> posAccessor;
+ private final DeleteCounter counter;
private PositionDeleteIndex deleteRowPositions = null;
- private Predicate<T> eqDeleteRows = null;
- protected DeleteFilter(String filePath, List<DeleteFile> deletes, Schema
tableSchema, Schema requestedSchema) {
+ protected DeleteFilter(String filePath, List<DeleteFile> deletes, Schema
tableSchema, Schema requestedSchema,
+ DeleteCounter counter) {
Review Comment:
Do we need to pass through the counter here? Seems like this should just be
an internal member of delete filter that is created with the delete filter? Or
is this just because we have no other way of getting the counter information
back out of the applied delete filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
