RussellSpitzer commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r888050255
##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -96,6 +105,10 @@ protected DeleteFilter(String filePath, List<DeleteFile>
deletes, Schema tableSc
this.posAccessor =
requiredSchema.accessorForField(MetadataColumns.ROW_POSITION.fieldId());
}
+ protected DeleteFilter(String filePath, List<DeleteFile> deletes, Schema
tableSchema, Schema requestedSchema) {
Review Comment:
Is this just for legacy compatibility? Do we have any users of this here? as
a protected method I would think we would be free to drop it if we wanted to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
