kbendick commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r889650944
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/source/TestStreamingMonitorFunction.java:
##########
@@ -208,6 +208,37 @@ public void testCheckpointRestore() throws Exception {
}
}
+ @Test
+ public void testConsumeWithDifferentMonitorSnapshotNumbers() throws
Exception {
+ List<List<Record>> recordsList = generateRecordsAndCommitTxn(10);
+
+ for (int monitorNumber = 1; monitorNumber < 11; monitorNumber =
monitorNumber + 1) {
+ ScanContext scanContext = ScanContext.builder()
+ .monitorInterval(Duration.ofMillis(100))
+ .monitorSnapshotNumber(monitorNumber)
+ .build();
Review Comment:
It’s always better in my opinion to throw on an invalid configuration vs try
to adjust for the user’s behavior (unless we introduced the bug in which case
we should take that case by case).
We should check that it’s non-negative in a Precondition check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
