kbendick commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r889651104
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -155,6 +162,12 @@ private void monitorAndForwardSplits() {
if (lastSnapshotId == INIT_LAST_SNAPSHOT_ID) {
newScanContext = scanContext.copyWithSnapshotId(snapshotId);
} else {
+ List<Long> snapshotIds = SnapshotUtil.snapshotIdsBetween(table,
lastSnapshotId, snapshot.snapshotId());
+ if (snapshotIds.size() < scanContext.monitorSnapshotNumber()) {
+ snapshotId = snapshot.snapshotId();
+ } else {
+ snapshotId = snapshotIds.get(snapshotIds.size() -
scanContext.monitorSnapshotNumber());
+ }
Review Comment:
I do like the idea of using the snapshot ID though generally speaking (in
this case I need to review).
However, It’s possible to turn off snapshot ID inheritance. So we’d need to
consider that.
EDIT - We have assertions on snapshot ID inheritance within this class
already so that’s fair to consider imo 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
