kbendick commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r889652532
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -339,6 +351,11 @@ Builder planParallelism(Integer parallelism) {
return this;
}
+ Builder monitorSnapshotNumber(int newMonitorSnapshotNumber) {
+ this.monitorSnapshotNumber = newMonitorSnapshotNumber;
Review Comment:
+1. A precondition check. And INT_MAX can be the value that disables this
behavior.
Or a negative value (eg -1). A negative value is probably more in-line with
what we typically do and more cross-language friendly (as Iceberg table format
is a specification first and foremost… it should be able to be rewritten in a
language that doesn’t have JVM INT_MAX).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
