stevenzwu commented on code in PR #4943:
URL: https://github.com/apache/iceberg/pull/4943#discussion_r889712789
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/StreamingMonitorFunction.java:
##########
@@ -134,15 +140,33 @@ public void snapshotState(FunctionSnapshotContext
context) throws Exception {
public void run(SourceContext<FlinkInputSplit> ctx) throws Exception {
this.sourceContext = ctx;
while (isRunning) {
+ LOG.debug("Start polling snapshots from snapshot id: {},
max-snapshots-per-monitor-interval: {}", lastSnapshotId,
+ scanContext.maxSnapshotsPerMonitorInterval());
+ long start = System.currentTimeMillis();
+ long startSnapshotId = lastSnapshotId;
synchronized (sourceContext.getCheckpointLock()) {
if (isRunning) {
monitorAndForwardSplits();
}
}
+ LOG.debug("Forwarded splits from {}(exclusive) to {}(inclusive), time
elapsed {}ms",
+ startSnapshotId, lastSnapshotId, System.currentTimeMillis() - start);
Thread.sleep(scanContext.monitorInterval().toMillis());
}
}
+ private long maxReachableSnapshotId(long lastConsumedSnapshotId, long
latestSnapshotId,
+ int maxSnapshotsPerMonitorInterval) {
+ List<Long> snapshotIds = SnapshotUtil.snapshotIdsBetween(table,
lastConsumedSnapshotId, latestSnapshotId);
+
+ if (snapshotIds.size() <= maxSnapshotsPerMonitorInterval) {
+ return latestSnapshotId;
+ } else {
+ // This doesn't consider snapshot inheritance since it is already
checked in state initialization.
+ return snapshotIds.get(snapshotIds.size() -
maxSnapshotsPerMonitorInterval);
Review Comment:
This logic seems incorrect to me. `SnapshotUtil.snapshotIdsBetween` returns
the snapshot ids in the reverse order (most recent snapshot first). I think we
need to use the reversed list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
