wypoon commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r890758865
##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -139,7 +193,21 @@ protected void dropTable(String name) {
}
@Override
- public StructLikeSet rowSet(String name, Table table, String... columns) {
+ protected boolean countDeletes() {
Review Comment:
I removed the `deleteCount` field and the `setDeleteCount(long)` method, and
the `deleteCount()` method now simply calls a `lastExecutedMetricValue(...)`
method along the lines you suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
