kbendick commented on code in PR #5118:
URL: https://github.com/apache/iceberg/pull/5118#discussion_r907745575
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -336,4 +348,8 @@ private static TableMetadata commit(TableOperations ops,
UpdateTableRequest requ
return ops.current();
}
+
+ private static String metadataLocation(Table tbl) {
+ return ((HasTableOperations)
tbl).operations().current().metadataFileLocation();
+ }
Review Comment:
Currently unused - was using to check the metadata file location in some of
the failing tests. It's only intermediate results that have a
`LoadTableResponse` without a metadataLocation (e.g. if `stageCreate` is being
called).
So maybe `metadata-location` should be nullable as `LoadTableResponse` can
be returned without it? Or we need to be adding it somewhere in the responses
that we're not inside of `RESTSessionCatalog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
