kbendick commented on code in PR #5118:
URL: https://github.com/apache/iceberg/pull/5118#discussion_r907805539
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java:
##########
@@ -106,6 +113,8 @@ public Builder addAllConfig(Map<String, String> properties)
{
public LoadTableResponse build() {
Preconditions.checkNotNull(metadata, "Invalid metadata: null");
+ // This is causing errors in TestRESTCatalog via CatalogHandlers
+ // Preconditions.checkNotNull(metadataLocation, "Invalid metadata
location: null");
Review Comment:
There's a call to the builder somewhere that's used during the
`CatalogTests` that is creating a `LoadTableResponse` without a metadata
location.
I think it's somewhere related to here
https://github.com/apache/iceberg/blob/e0ff3c6e9876ce04c890908e375c876d14240c3e/core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java#L160-L195,
or some other create transaction that doesn't commit right away. Will
investigate further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
