kbendick commented on code in PR #5118:
URL: https://github.com/apache/iceberg/pull/5118#discussion_r907820005
##########
core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java:
##########
@@ -106,6 +113,8 @@ public Builder addAllConfig(Map<String, String> properties)
{
public LoadTableResponse build() {
Preconditions.checkNotNull(metadata, "Invalid metadata: null");
+ // This is causing errors in TestRESTCatalog via CatalogHandlers
+ Preconditions.checkNotNull(metadataLocation, "Invalid metadata location:
null");
Review Comment:
This is the check that is causing 16 test failures in `TestRESTCatalog` -
which has been reduced to 13 by the changes in `CatalogHandlers`.
Without this check, all tests in `TestRESTCatalog` pass. See notes here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
