kbendick commented on code in PR #5118:
URL: https://github.com/apache/iceberg/pull/5118#discussion_r908141355
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -189,8 +194,12 @@ public static LoadTableResponse stageTableCreate(Catalog
catalog, Namespace name
location,
properties);
+ TableMetadata metadataWithLocation = TableMetadata.buildFrom(metadata)
+ .withMetadataLocation(metadataLocation)
+ .build();
+
return LoadTableResponse.builder()
- .withTableMetadata(metadata)
+ .withTableMetadata(metadataWithLocation)
Review Comment:
We've determined that `metadata-location` should not be required,
specifically as a `LoadTableResponse` might be returned in response to a
request to stage the creation of a table (i.e. during a transaction).
But given that the table _does_ have `metadata-location` by this point in
time, we should add it to the response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
